HDDS-8734. OM DB cache metrics creation should be idempotent #4805
Conversation
|
@sumitagrawl @ChenSammi - pls review |
devmadhuu
changed the title
sumitagrawl
left a comment
sumitagrawl
left a comment
There was a problem hiding this comment.
@devmadhuu thanks working over this, plz add some test case for this
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @devmadhuu for working on this.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
Outdated
Show resolved
Hide resolved
|
@DaveTeng0 - pls review for acceptance test impact |
|
Thanks @devmadhuu for updating the patch. |
|
@devmadhuu acceptance test failure is unrelated, already encountered the same on |
adoroszlai
changed the title
Thanks @sumitagrawl for reviewing. I have added the test case. Pls re-review. |
Thank you @adoroszlai for review. |
|
@adoroszlai - Pls re-review and if all looks good, pls merge. |
|
@adoroszlai As part of #4678 , I have fixed the test case can you review this. |
4 participants
What changes were proposed in this pull request?
When a cache metrics being registered for any OM DB table, it should check if cache metrics already registered or not. If it is already registered, then we should unregister first and allow registration.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8734
How was this patch tested?
This patch was tested using existing unit test cases including initialisation of new snapshot OM DB in Recon and do registration of cache metrics tables.